Skip to content

Awkward 2.0 support in servicex 2.0 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2023
Merged

Awkward 2.0 support in servicex 2.0 #317

merged 8 commits into from
Sep 22, 2023

Conversation

@gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented Sep 22, 2023 •
edited
Loading

Enable awkward 2.0 support in servicex

  • Setup configured to support only awkward 1.0 if you are on python 3.7 (we need to drop support for this!)
  • If you load a awkward array using this library, it will give you an awkward_dask array if awkward 2.0 is loaded, or a lazy array if awkward 1.0 is in your environment.

Fixes #316

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.09% ⚠️

Comparison is base (9789b7d) 98.53% compared to head (ff11ce8) 98.45%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   98.53%   98.45%   -0.09%     
==========================================
  Files          12       12              
  Lines        1160     1164       +4     
==========================================
+ Hits         1143     1146       +3     
- Misses         17       18       +1
Flag Coverage Δ
unittests-3.10 98.36% <71.42%> (-0.17%) ⬇️
unittests-3.11 98.36% <71.42%> (-0.17%) ⬇️
unittests-3.7 98.27% <57.14%> (-0.26%) ⬇️
unittests-3.8 98.36% <71.42%> (-0.17%) ⬇️
unittests-3.9 98.36% <71.42%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
servicex/data_conversions.py 98.24% <85.71%> (-1.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonwatts
Copy link
Collaborator Author

gordonwatts commented Sep 22, 2023

This is a stop-gap fix until 3.0 is released, so I'm not too worried about the drop in code coverage.

@gordonwatts gordonwatts changed the title Pr_awkward_in_20 Awkward 2.0 support in servicex 2.0 Sep 22, 2023
@gordonwatts gordonwatts self-assigned this Sep 22, 2023
@gordonwatts gordonwatts added the enhancement New feature or request label Sep 22, 2023
BenGalewsky
BenGalewsky approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we can evolve

@gordonwatts gordonwatts merged commit 9341628 into master Sep 22, 2023
@gordonwatts gordonwatts deleted the pr_awkward_in_20 branch September 22, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenGalewsky BenGalewsky BenGalewsky approved these changes

Assignees

@gordonwatts gordonwatts

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support awkward 2.0

3 participants

@gordonwatts @BenGalewsky